Skip to content

Update lib.ts to support exports that start with $ and _ #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update lib.ts to support exports that start with $ and _ #51

wants to merge 1 commit into from

Conversation

@nicksrandall
Copy link

This will detect exports that start with $ and _.

Here is a snippet from @lexical/html that was causing an issue for me:

exports.$generateHtmlFromNodes = $generateHtmlFromNodes;
exports.$generateNodesFromDOM = $generateNodesFromDOM;

The updated regex will correctly identify this module as common-js.

@nicksrandall
Copy link
Author

Anything I can do to help this get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nicksrandall